BUG: Holiday observance rules could not be applied #11484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if self.observance is not None or self.offset is not None: | ||
| # NOTE: Arbitrary offset to ensure that any offsets | ||
| # or observance rules will get applied |
There was a problem hiding this comment.
hmm, maybe have a private method which find the next/previous one?
|
@jreback Changes incorporated. Holiday.dates() does return a DatetimeIndex rather than a list, but I'm thinking that's okay. |
|
|
||
| .. ipython:: python | ||
|
|
||
| from pandas.tseries.offsets import CDay |
There was a problem hiding this comment.
can you format the same (i think too much indent)
|
@rockg looks good. pls rebase / minor edits. ping when green. |
|
@jreback Green |
jreback
added a commit
that referenced
this pull request
Nov 14, 2015
BUG: Holiday observance rules could not be applied
|
thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11477
Closes #11533
There were some other bugs here that I added tests for. For example,
holiday.datesfor MLK day was returning all holidays from the holiday start date up to the end date rather than just between the range.